fix(spdmlib/session): clear backup flags and transcript hashes on reset#371
Merged
jyao1 merged 1 commit intoccc-spdm-tools:mainfrom Apr 28, 2026
Conversation
Extend `SpdmSession::set_default()` to also reset `responder_backup_valid`, `requester_backup_valid`, `th1`, and `th2`. Without these resets, a session struct that is recycled after teardown or reset retains values from the previous connection. An attacker could leverage this leakage to manipulate key updates or poison transcript hashes in future SPDM sessions. Signed-off-by: Stanislaw Grams <stanislaw.grams@intel.com>
jyao1
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend
SpdmSession::set_default()to also resetresponder_backup_valid,requester_backup_valid,th1, andth2. Without these resets, a session struct that is recycled after teardown or reset retains values from the previous connection.An attacker could leverage this leakage to manipulate key updates or poison transcript hashes in future SPDM sessions.